react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[iOS] Remove invalidate observer instead of re-adding observer in DeviceInfo module

Open zhongwuzw opened this issue 1 year ago • 2 comments

Summary:

Previous fix brings in https://github.com/facebook/react-native/pull/42396. Seems it's a mistake to re-add observer? So let's remove it and also not invalidate method not be called twice.

Changelog:

[IOS] [FIXED] - Remove invalidate observer instead of re-adding observer in DeviceInfo module

Test Plan:

Fix for #42120 also works.

zhongwuzw avatar Apr 01 '24 07:04 zhongwuzw

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,877,269 -9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,250,201 +4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 220588004b100717b0984bf33a48391746ecd3ff Branch: main

analysis-bot avatar Apr 01 '24 08:04 analysis-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 03 '24 13:04 facebook-github-bot

This pull request was successfully merged by @zhongwuzw in 91279a822be949051866a694148e509c1308035b.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 04 '24 14:04 github-actions[bot]