react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Remove unused names in component mapping

Open Sunbreak opened this issue 1 year ago • 5 comments

Summary:

  • react-native-slider use RNCSlider not RCTSlider: https://github.com/callstack/react-native-slider/blob/166ec7f3e7c853ab3be3da132c726dd8442b3874/package/ios/RNCSliderManager.m#L15-L20
  • react-native-video doesn't support Fabric on stable release: https://github.com/react-native-video/react-native-video/issues/2650
  • react-native-maps use AIRMap not RCTMap: https://github.com/react-native-maps/react-native-maps/blob/fca4ad7b2eb53a81814bdcd69d80f81620ea1a2a/ios/AirMaps/AIRMapManager.m#L36-L46
  • react-native-webview use RNCWebView not RCTWebView: https://github.com/react-native-webview/react-native-webview/blob/4197bb42ce79406ff20c7e5637f78e44ca45474c/apple/RNCWebViewManager.mm#L44
  • Shimmer is deprecated: https://github.com/facebookarchive/Shimmer

TemplateView, AxialGradientView, Keyframes and ImpressionTrackingView seem to be internal only and Google found nothing

Changelog:

[GENERAL] [REMOVED] - Remove unused names in component mapping

Test Plan:

none

Sunbreak avatar Mar 16 '24 13:03 Sunbreak

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,127,336 +11
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,493,890 +11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f2f62cdf54b5aff565466fd340685d88bb975bac Branch: main

analysis-bot avatar Mar 16 '24 14:03 analysis-bot

Thanks for this. I'll import it for now, but we may need some internal refactoring to make sure we don't depend on this for our internal dependencies.

javache avatar Mar 18 '24 10:03 javache

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 18 '24 10:03 facebook-github-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Sep 15 '24 05:09 react-native-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Sep 15 '24 05:09 react-native-bot

This PR was closed because it has been stalled for 7 days with no activity.

react-native-bot avatar Sep 22 '24 05:09 react-native-bot