react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Do not crash on onJSBundleLoadedFromServer when fast-refreshing on bridgeless mode

Open cortinico opened this issue 1 year ago • 3 comments

Summary: RN-Tester is currently instacrashing on fast-refresh (pressing r on Metro) as it ends up on onJSBundleLoadedFromServer which throws an exception on Bridgeless mode. I'm fixing it by following the same logic as onReloadWithJSDebugger.

Changelog: [Android] [Fixed] - Do not crash on onJSBundleLoadedFromServer when fast-refreshing on bridgeless mode

Differential Revision: D54121838

cortinico avatar Feb 23 '24 17:02 cortinico

This pull request was exported from Phabricator. Differential Revision: D54121838

facebook-github-bot avatar Feb 23 '24 17:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54121838

facebook-github-bot avatar Feb 23 '24 17:02 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,000,690 +7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,359,066 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2647dc8c3976e2e8763faa3f4a23b59e9a0ad218 Branch: main

analysis-bot avatar Feb 23 '24 18:02 analysis-bot

Closed by 44e5bc9e2c73235ba5d8bf0f5323181948e74197

cortinico avatar Feb 26 '24 18:02 cortinico