react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Use host-relative WebSocket URLs when launching new debugger

Open motiz88 opened this issue 1 year ago • 2 comments

Summary: Changelog: [Internal]

Uses the capability introduced in https://github.com/facebookexperimental/rn-chrome-devtools-frontend/pull/4 to avoid repeating the dev server's host:port in the ws / wss parameter we pass to the Chrome DevTools frontend. This gives us more flexibility to handle port forwarding and redirects outside of dev-middleware. This is mostly useful in Meta's internal VS Code remoting setup, but this particular change should work equally well in open source.

Differential Revision: D54107316

motiz88 avatar Feb 23 '24 10:02 motiz88

This pull request was exported from Phabricator. Differential Revision: D54107316

facebook-github-bot avatar Feb 23 '24 10:02 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,882,129 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,240,573 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 12f2c3cd2bbf186afe1b4052ebf377d8030c7a73 Branch: main

analysis-bot avatar Feb 23 '24 11:02 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D54107316

facebook-github-bot avatar Feb 26 '24 11:02 facebook-github-bot

451fffbb59ceafdb84d7345592db65689a03256e

cortinico avatar Apr 02 '24 10:04 cortinico