react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Enable the native module for feature flags by default for iOS apps in OSS

Open rubennorte opened this issue 1 year ago • 7 comments

Summary: Changelog: [internal]

This modifies the default RCTAppDelegate for iOS apps in OSS to provide an implementation for the C++ native module for feature flags.

In a following diff I'll replace the React-featureflagsnativemodule.podspec file with one that includes all built-in C++ native modules.

Differential Revision: D54082349

rubennorte avatar Feb 22 '24 20:02 rubennorte

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 22 '24 20:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 22 '24 20:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 22 '24 20:02 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,000,687 +4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,359,073 +9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 073ca1aa03f74454d51dd6fa63f5c094e283e633 Branch: main

analysis-bot avatar Feb 22 '24 20:02 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 22 '24 21:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 22 '24 22:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 22 '24 22:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54082349

facebook-github-bot avatar Feb 23 '24 07:02 facebook-github-bot

This pull request has been merged in facebook/react-native@0eac4181cce6d493213404348811cff317b6c4a3.

facebook-github-bot avatar Feb 23 '24 09:02 facebook-github-bot