react-native
react-native copied to clipboard
Unify BUCK and CMake includes for Cxx modules
Summary:
This diff adds the react/renderer/components prefix to the generated CMakeLists.txt file for the Cxx modules.
This will allow to import the generated JSI header also like this
#include <MyModule/MyModuleJSI.h>
and not just like this
#include "MyModuleJSI.h"
This will make CMake includes consistent with BUCK includes, and we'll reduce the number of awkward ifdefs in the include section.
Changelog: [General][Changed] - Unify BUCK and CMake includes for Cxx modules.
Differential Revision: D54063743
This pull request was exported from Phabricator. Differential Revision: D54063743
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 17,935,058 | -3 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 21,293,291 | +7 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 767330f21885e668bc0d9b5b3063113d0446bcbc Branch: main
This pull request was exported from Phabricator. Differential Revision: D54063743