react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Pull PopupMenuAndroid out of React Native core

Open RSNara opened this issue 1 year ago • 5 comments

Summary: History: This component was originally introduced into React Native core in D52712758, to replace UIManagerModule.showPopupMenu().

Problem: But, React Native core should be lean. Adding this component to React Native bloats the core.

Changes: So, this diff pulls PopupMenuAndroid out into its own package in the react-native GitHub repository.

In the future, this will be migrated to a community package!

Changelog: [Removed][Android] Move PopupMenu out of React Native core

Reviewed By: NickGerleman

Differential Revision: D53328110

RSNara avatar Feb 16 '24 19:02 RSNara

This pull request was exported from Phabricator. Differential Revision: D53328110

facebook-github-bot avatar Feb 16 '24 19:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53328110

facebook-github-bot avatar Feb 19 '24 22:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53328110

facebook-github-bot avatar Feb 21 '24 00:02 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,816,434 -118,619
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,174,771 -118,502
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f3e132bb0b54f67970e9f946d97fac06c0b4868b Branch: main

analysis-bot avatar Feb 21 '24 00:02 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D53328110

facebook-github-bot avatar Feb 21 '24 17:02 facebook-github-bot

Merged as 8bced4b29db9b41a68ef726df81449a399eff604

cortinico avatar Mar 04 '24 11:03 cortinico