react-native icon indicating copy to clipboard operation
react-native copied to clipboard

add privacy manifest to pod install

Open philIip opened this issue 1 year ago • 5 comments

Summary: Changelog: [iOS][Added]

this creates the RN privacy manifest in the ios build step if user has not created one yet.

Differential Revision: D53687232

philIip avatar Feb 13 '24 02:02 philIip

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,742,568 +10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,104,981 -11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3b2c4a18348892acf14120bc42fa1f54c261e914 Branch: main

analysis-bot avatar Feb 13 '24 03:02 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D53687232

facebook-github-bot avatar Feb 14 '24 04:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53687232

facebook-github-bot avatar Feb 14 '24 06:02 facebook-github-bot

@philIip - are you able to provide any additional context on the changes here? i've read https://developer.apple.com/support/third-party-SDK-requirements but i'm curious about what part of that this is solving in particular and why we're generating the file during the pod install step

brentvatne avatar Feb 15 '24 01:02 brentvatne

I've opened an issue to get more information about this: https://github.com/facebook/react-native/issues/43439

leocpadua7 avatar Mar 12 '24 14:03 leocpadua7

@philIip - are you able to provide any additional context on the changes here? i've read https://developer.apple.com/support/third-party-SDK-requirements but i'm curious about what part of that this is solving in particular and why we're generating the file during the pod install step

hi @brentvatne sorry i didn't see this at all, the high level discussion is here: https://github.com/react-native-community/discussions-and-proposals/discussions/776#discussion-6437392

philIip avatar Apr 10 '24 04:04 philIip

here's the landed version of this with a more high fidelity diff summary

https://github.com/facebook/react-native/commit/d39712f54a95e6dcdf1d2f80d9581211ab03c157?fbclid=IwAR0hozrbkckW3xpQ3GlRbllzJ2cCBvD_ZQYlxMd-FMsaWRFZ9vnR4qHeXuM

philIip avatar Apr 10 '24 04:04 philIip