react-native icon indicating copy to clipboard operation
react-native copied to clipboard

remove animation from borderLayer to stop unwanted animations

Open sammy-SC opened this issue 1 year ago • 1 comments

Summary: changelog: [fix][ios] prevent unwanted border animation

The problem: CALayer and its properties are animatable. If RN applies mutations inside an animation block, it will animate. In this particular example, it was animated because of a transition applied by the library and because we were not creating new views, but recycling views from previous screen.

This caused size of _borderLayer to change from value A to value B inside of animation block. To resolve this, call removeAllAnimations on borderLayer.

Reviewed By: cipolleschi

Differential Revision: D53566886

sammy-SC avatar Feb 08 '24 14:02 sammy-SC

This pull request was exported from Phabricator. Differential Revision: D53566886

facebook-github-bot avatar Feb 08 '24 14:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53566886

facebook-github-bot avatar Feb 09 '24 09:02 facebook-github-bot

This pull request has been merged in facebook/react-native@5fbdc994f945ee8d834632649e3b82451660e8fe.

facebook-github-bot avatar Feb 09 '24 12:02 facebook-github-bot