react-native
react-native copied to clipboard
facebook
Update tsconfig to not run on files inside Pods
Summary:
Opening the VisionOS fork crashes tsserver.js inside VSCode because of some Pods files. This stops tsserver from looking at any files inside Pods
Changelog:
Test Plan:
Hi @bartlomein!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Hey, just chiming in with additional context:
When Hermes is built from source it contains additional JS files that were picked up by Typescript Server and causing a crash. I don't think typescript should look into ios/Pods or visionos/Pods folders
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 17,233,443 | +11 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 20,600,121 | +6 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 665c40046079a69f1ccd6bc7fe3d56e81a9488f7 Branch: main
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cipolleschi merged this pull request in facebook/react-native@40bb425f48a65641b4882c08cf84be123b333bd6.