react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Do not serialize text attributes that are not used later

Open cubuspl42 opened this issue 1 year ago • 4 comments

Summary:

Do not serialize text attributes that are not used later

Changelog:

[INTERNAL] [REMOVED] - Do not serialize text attributes that are not used later

Test Plan:

cubuspl42 avatar Jan 29 '24 11:01 cubuspl42

@mdvacca I think I will need your eyes on this one.

Please see this thread.

cubuspl42 avatar Jan 29 '24 11:01 cubuspl42

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,066,827 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,450,423 -9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: cfc0ba04a1fa147517e94d1f952e2a8fe62e6e9c Branch: main

analysis-bot avatar Jan 29 '24 12:01 analysis-bot

@mdvacca What do you think? Is this a good way forward?

cubuspl42 avatar Feb 05 '24 09:02 cubuspl42

@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Feb 06 '24 04:02 facebook-github-bot

@mdvacca Let me know if I can help with making the internal build succeed

cubuspl42 avatar Feb 15 '24 09:02 cubuspl42

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 14 '24 05:08 react-native-bot