react-native
react-native copied to clipboard
De-duplicate the logic for counting attachments
Summary:
De-duplicate the logic for counting attachments.
This is a minor improvement in the context of my multi-PR work on https://github.com/react-native-community/discussions-and-proposals/issues/695.
Changelog:
[INTERNAL] [CHANGE] - De-duplicate the logic for counting attachments
Test Plan:
@rozele Any chance you could review this?
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 17,066,833 | +1 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 20,450,443 | +11 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: cfc0ba04a1fa147517e94d1f952e2a8fe62e6e9c Branch: main
@rozele I took a look at the "build_npm_package" check and it seems unrelated to my changes 🙂
@cipolleschi Thank you for reviewing and approving this PR! What is the next action point here? 🙂
/rebase - this comment automatically rebase the PR on top of main
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
I'm soooo sorry! I was sure we already merged this PR in main. 🤦 I'll proceed importing and have it landed.
@cipolleschi merged this pull request in facebook/react-native@69977d05f005c93923a257aae9f5e06957fe8bc7.