[iOS] Fabric: Fixes Modal present splash when animation type is none
Summary:
Because the modal layout is triggered by state, it's an async operation after the first mount, so we can see the splash when present modal. now we can pass the screen size to the initial state which can layout in the first mount operation.
before: https://github.com/facebook/react-native/assets/5061845/a39d519e-e2f6-42f1-8319-6216c88e9cf3
After: https://github.com/facebook/react-native/assets/5061845/c7d59820-399b-4ea2-943d-d889971ea7ee
Changelog:
[IOS] [FIXED] - Fabric: Fixes Modal present splash when animation type is none
Test Plan:
RNTester Modal example, present modal in none animation mode.
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 21,284,141 | +2 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 24,481,165 | +0 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 12b64b78247f2db929c6d421262bdec1f6402e0b Branch: main
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@dmytrorykun Hi, friendly ping, any progress on reviewing this PR?
Sorry if this is taking too long. It is in my queue and I'll get to it at some point, hopefully soon!
Merge main branch to fix the conflict.
@cipolleschi Hi, any chance to keep forward this PR? :)
Let me import this and let's see if some colleague has some ideas on how to approach this better or if they are happy with this! :D
@cipolleschi merged this pull request in facebook/react-native@14de1b708a637313f34aa0806e5c6f0ea6bb7417.
This pull request was successfully merged by @zhongwuzw in 14de1b708a637313f34aa0806e5c6f0ea6bb7417
When will my fix make it into a release? | How to file a pick request?