react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[iOS] Fabric: Fixes Modal present splash when animation type is none

Open zhongwuzw opened this issue 2 years ago • 7 comments

Summary:

Because the modal layout is triggered by state, it's an async operation after the first mount, so we can see the splash when present modal. now we can pass the screen size to the initial state which can layout in the first mount operation.

before: https://github.com/facebook/react-native/assets/5061845/a39d519e-e2f6-42f1-8319-6216c88e9cf3

After: https://github.com/facebook/react-native/assets/5061845/c7d59820-399b-4ea2-943d-d889971ea7ee

Changelog:

[IOS] [FIXED] - Fabric: Fixes Modal present splash when animation type is none

Test Plan:

RNTester Modal example, present modal in none animation mode.

zhongwuzw avatar Dec 08 '23 15:12 zhongwuzw

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,284,141 +2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,481,165 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 12b64b78247f2db929c6d421262bdec1f6402e0b Branch: main

analysis-bot avatar Dec 08 '23 15:12 analysis-bot

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Dec 08 '23 16:12 facebook-github-bot

@dmytrorykun Hi, friendly ping, any progress on reviewing this PR?

zhongwuzw avatar Jan 31 '24 02:01 zhongwuzw

Sorry if this is taking too long. It is in my queue and I'll get to it at some point, hopefully soon!

cipolleschi avatar Apr 10 '24 11:04 cipolleschi

Merge main branch to fix the conflict.

zhongwuzw avatar Jun 18 '24 12:06 zhongwuzw

@cipolleschi Hi, any chance to keep forward this PR? :)

zhongwuzw avatar Jul 09 '24 04:07 zhongwuzw

Let me import this and let's see if some colleague has some ideas on how to approach this better or if they are happy with this! :D

cipolleschi avatar Jul 09 '24 12:07 cipolleschi

@cipolleschi merged this pull request in facebook/react-native@14de1b708a637313f34aa0806e5c6f0ea6bb7417.

facebook-github-bot avatar Jul 18 '24 17:07 facebook-github-bot

This pull request was successfully merged by @zhongwuzw in 14de1b708a637313f34aa0806e5c6f0ea6bb7417

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Jul 18 '24 17:07 react-native-bot