react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Fix comments on Flipper build failure condition & syntax error

Open AmeyShrivastava opened this issue 2 years ago • 5 comments

Summary:

This commit addresses two main points:

  1. It updates the comments to clarify the conditions under which the iOS build will fail when using react-native-flipper. The comment build failure condition has been changed from when NO_FLIPPER=1 is set to when NO_FLIPPER=1 is not set. This change helps to accurately reflect the accompanying code.

  2. A syntax error in the react-native.config.js code snippet has been fixed by adding a missing closing }

Changelog:

Fix comments on Flipper build failure condition & syntax error

Pick one each for the category and type tags:

[GENERAL] [FIXED] - comments on Flipper build failure condition & minor syntax error

Test Plan:

“Changes limited to comments only

AmeyShrivastava avatar Nov 08 '23 14:11 AmeyShrivastava

Hi @AmeyShrivastava!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 08 '23 14:11 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,492,332 -9,149,515
android hermes armeabi-v7a 7810353 n/a
android hermes x86 8962362 n/a
android hermes x86_64 8823755 n/a
android jsc arm64-v8a 9,151,478 -11,870,131
android jsc armeabi-v7a 8341168 n/a
android jsc x86 9204655 n/a
android jsc x86_64 9463477 n/a

Base commit: 47f773e45813d3281fa7755996d0ff5e26f6888e Branch: main

analysis-bot avatar Nov 08 '23 15:11 analysis-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Nov 08 '23 16:11 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Nov 08 '23 16:11 facebook-github-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 07 '24 05:05 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 14 '24 05:05 github-actions[bot]