react-native
react-native copied to clipboard
reuse existing source URL for bridgeless
Summary: Changelog: [iOS][Breaking]
so i was thinking that the getBundleURL API that we added on the app delegate is redundant since all working apps will have the source url provided in sourceURLForBridge:. i briefly perused GH: https://github.com/search?q=sourceURLForBridge&type=code, and it seems no one actually needs the bridge to generate this url.
i think there's an opportunity to remove a step from the upgrade flow by either:
- getting rid of
getBundleURLand reusesourceURLForBridge: - fallback to
sourceURLForBridge:ingetBundleURL
in this diff, i ended up going with 1), but i'm open to options. the tricky thing is that sourceURLForBridge: implies the old architecture.
Differential Revision: D48141201
This pull request was exported from Phabricator. Differential Revision: D48141201
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 8,891,055 | -2 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 9,482,839 | -2 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: fdab18b0a1f30540400abf05fa3f56ca002fefca Branch: main
This pull request was exported from Phabricator. Differential Revision: D48141201
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity.