react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

fix(ios): set top of perf monitor to statusbar height

Open zerosrat opened this issue 2 years ago • 1 comments

Update RCTPerfMonitor.mm

Summary:

Change the top offset of perf monitor component. As it is overlapped by dynamic island of iPhone 14 Pro series.

Before: image

After: image

Changelog:

[iOS] [Fixed] - Change the top of perf monitor component.

Test Plan:

noop

zerosrat avatar Jul 09 '23 11:07 zerosrat

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,001,914 +452
android hermes armeabi-v7a 8,255,976 +601
android hermes x86 9,511,053 +547
android hermes x86_64 9,356,938 +569
android jsc arm64-v8a 9,614,948 +419
android jsc armeabi-v7a 8,741,584 +557
android jsc x86 9,701,900 +516
android jsc x86_64 9,948,457 +514

Base commit: 0519c11acd0c347db378bbc9238c7dabfd38f6fa Branch: main

analysis-bot avatar Jul 09 '23 11:07 analysis-bot

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 10 '23 05:07 facebook-github-bot

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 11 '23 14:07 facebook-github-bot

@NickGerleman merged this pull request in facebook/react-native@5ba8de05b5e6c170b84b44979e7bbc576442eafb.

facebook-github-bot avatar Jul 11 '23 17:07 facebook-github-bot