react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Remove run Metro hook from Xcode build, remove launchPackager scripts

Open huntie opened this issue 2 years ago • 2 comments

Summary: See proposal: https://github.com/react-native-community/discussions-and-proposals/discussions/681

Removed script files

I searched GitHub (and specifically react-native-windows/macos) to confirm these files are not referenced:

  • scripts/launchPackager.bat
  • scripts/launchPackager.command
  • scripts/.packager.env

Interestingly, React Native CLI refers to a .packager.env at a different location (node_modules/.bin/), and includes modified copies of launchPackager.command/bat. This PR removes duplication with these.

Changelog: [iOS][Changed] Metro will no longer be started when running builds via Xcode

Differential Revision: D47297469

huntie avatar Jul 07 '23 17:07 huntie

This pull request was exported from Phabricator. Differential Revision: D47297469

facebook-github-bot avatar Jul 07 '23 17:07 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,001,915 -1
android hermes armeabi-v7a 8,255,978 -1
android hermes x86 9,511,054 -1
android hermes x86_64 9,356,939 +0
android jsc arm64-v8a 9,614,949 -1
android jsc armeabi-v7a 8,741,584 +1
android jsc x86 9,701,902 -2
android jsc x86_64 9,948,458 +0

Base commit: c82f2e9f6816a1f946bad326e6f927018b4b05a8 Branch: main

analysis-bot avatar Jul 07 '23 17:07 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D47297469

facebook-github-bot avatar Jul 10 '23 11:07 facebook-github-bot

This pull request was successfully merged by @huntie in dc6845739e29ea8cf63583d530f67c2498286a3e.

When will my fix make it into a release? | Upcoming Releases

github-actions[bot] avatar Jul 10 '23 12:07 github-actions[bot]

This pull request has been merged in facebook/react-native@dc6845739e29ea8cf63583d530f67c2498286a3e.

facebook-github-bot avatar Jul 10 '23 12:07 facebook-github-bot