Bump NDK to 25

[szymonrybczak]

Summary:

Bumps NDK to current LTS Release.

Changelog:

[Android] [Changed] - Bump NDK to 25

Test Plan:

CI Green ✅

[szymonrybczak]

Looks like CircleCI's machine broke on installing dependencies on iOS 🥲

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,889,374	+46,093
android	hermes	armeabi-v7a	7,939,885	-212,536
android	hermes	x86	9,287,256	-61,791
android	hermes	x86_64	9,191,068	-733
android	jsc	arm64-v8a	9,478,667	+22,655
android	jsc	armeabi-v7a	8,421,751	-215,392
android	jsc	x86	9,462,239	-76,855
android	jsc	x86_64	9,779,136	-3,251

Base commit: d3c28d28a9b5324310f0d86c284d3d8ffd63615b Branch: main

[szymonrybczak]

@cortinico Yeah, so: FBJNI - 23.1.7779620 Hermes - Not sure, where to find it. Flipper - 25.1.8937393 I can create PRs bumping versions in those repositories. Yes, I can look at ReactAndroid, is just doing that - will be okay in build.gradle.kts?

val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: "25.2.9519653")

Also I think we can bump NDK version in the docker-android, WDYT?

[cortinico]

FBJNI - 23.1.7779620

I'm currently working on it. Will be out with FBJNI version 0.5.0 sometime soon

Hermes - Not sure, where to find it.

This is controlled by ReactAndroid/hermes-engine/build.gradle so it will be bumped with everything.

Flipper - 25.1.8937393

That's correct as that's the version we want to use actually (see https://developer.android.com/build/releases/gradle-plugin#compatibility-8-0-0 as the default for 8.0.0).

We'll have to find which version of Flipper is the first one that bumped NDK to 25 and make sure we use it.

[cortinico]

Also I think we can bump NDK version in the docker-android, WDYT?

Yup that's also needed 🙏

[szymonrybczak]

We'll have to find which version of Flipper is the first one that bumped NDK to 25 and make sure we use it.

It was bumped in this PR https://github.com/facebook/flipper/pull/4443, and it was first released in 0.187.1, btw. just out of curiosity why the first one?

Yup that's also needed 🙏

PR: https://github.com/react-native-community/docker-android/pull/204

[cortinico]

and it was first released in 0.187.1, btw. just out of curiosity why the first one?

Because we might already have it shipped/bumped, but that's not the case as we're on 0.182.0

[cortinico]

@szymonrybczak can we move this forward?

[szymonrybczak]

Yeah, sure. So I updated the version to 25.1.8937393 (as it is the default for 8.0.0) in template and also in ReactAndroid. And I check the status of bumping to NDK 25 inside dependencies, and it looks like this: FBJNI - Bumped, but not released yet. Flipper - Not bumped in RN repository. docker-android - Bumped, but not released yet.

[cortinico]

FBJNI - Bumped, but not released yet. docker-android - Bumped, but not released yet.

I will take of those two next week.

Flipper - Not bumped in RN repository.

@szymonrybczak do you want to attempt to do this bump? It should be fairly easy (just search for a previous Flipper bump) 👍 I can support if needed

[cortinico]

Hey @szymonrybczak Sorry this took longer for me, but now we should be fully unblocked:

https://github.com/facebookincubator/fbjni/releases/tag/v0.5.0 https://github.com/react-native-community/docker-android/releases/tag/v10.0

Can I ask you to bump those 2 and rebase? And we should be able to import this 👍

[github-actions[bot]]

	Warnings
:warning:	:lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by :no_entry_sign: dangerJS against cc92bcc1b7c9db64f08ac9d17e6fa8da8f9ff58b

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cortinico merged this pull request in facebook/react-native@28deaa3a71085dc877da7f68dcec78c63bd9192a.