react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Extract task execution to a separate method in RuntimeScheduler

Open rubennorte opened this issue 2 years ago • 4 comments

Summary: Small refactor in preparation to add systrace markers for several methods in RuntimeScheduler.

Extracts the logic to execute a task to a private method and removes incorrect const modifier from some methods.

Changelog: [internal]

Differential Revision: D46556398

rubennorte avatar Jun 14 '23 13:06 rubennorte

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Jun 14 '23 13:06 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,333,767 +65
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,573,309 +62
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5323221d1442d1573bc65daff618478cb6f056f0 Branch: main

analysis-bot avatar Jun 14 '23 13:06 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Jun 14 '23 16:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Jun 15 '23 09:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Jul 20 '23 15:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Sep 15 '23 12:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Sep 18 '23 15:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Sep 19 '23 10:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Sep 19 '23 10:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Sep 19 '23 13:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46556398

facebook-github-bot avatar Sep 19 '23 14:09 facebook-github-bot

This pull request has been merged in facebook/react-native@b38a9dedd3eac664a3f0f85ea7938ff04c7148fd.

facebook-github-bot avatar Sep 19 '23 16:09 facebook-github-bot