react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Use new getCanonicalName and getMessage methods exposed by fbjni

Open krystofwoldrich opened this issue 2 years ago • 1 comments

Summary:

When a new version of fbjni is released, we can simplify getName and getMessage calls on throwables.

Changelog:

[ANDROID] [CHANGED] - Use new getCanonicalName and getMessage methods exposed by fbjni

Test Plan:

https://github.com/facebookincubator/fbjni/pull/78

krystofwoldrich avatar Jun 14 '23 12:06 krystofwoldrich

fbjni 0.3.1 isn't shipped yet, right? I have a pending cleanup blocked on that too (I expect it to be 0.4.0 at this point).

javache avatar Jun 14 '23 12:06 javache

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,749,345 -217,082
android hermes armeabi-v7a 8,061,144 -166,467
android hermes x86 9,240,401 -239,684
android hermes x86_64 9,090,309 -232,246
android jsc arm64-v8a 9,311,934 -215,422
android jsc armeabi-v7a 8,501,075 -164,812
android jsc x86 9,373,885 -238,023
android jsc x86_64 9,627,893 -230,581

Base commit: ede86a3c0c283f129727f14cda60a759fad8bfbf Branch: main

analysis-bot avatar Jun 22 '23 15:06 analysis-bot

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 23 '23 09:06 facebook-github-bot

This pull request was successfully merged by @krystofwoldrich in 6c729acd12933d79aae3ef05dbdecfa0feb96bf4.

When will my fix make it into a release? | Upcoming Releases

github-actions[bot] avatar Jun 23 '23 11:06 github-actions[bot]