react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Fix grouping of console logs

Open mattbfb opened this issue 2 years ago • 6 comments

Summary: Chrome Dev Tools doesn't correctly display grouped console logs (i.e. console output between a console.group and console.groupEnd) when timestamps are all zero.

Populate the timestamp field so grouping functions as expected.

Differential Revision: D46605659

mattbfb avatar Jun 12 '23 21:06 mattbfb

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 12 '23 21:06 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,042,649 -40
android hermes armeabi-v7a 8,292,334 -152
android hermes x86 9,559,284 -8
android hermes x86_64 9,401,374 +12
android jsc arm64-v8a 9,601,860 +6
android jsc armeabi-v7a 8,728,988 +6
android jsc x86 9,689,350 +5
android jsc x86_64 9,935,421 +6

Base commit: a28881a3d79e732670157638aa5207c88c79718c Branch: main

analysis-bot avatar Jun 12 '23 21:06 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 12 '23 23:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 13 '23 19:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 13 '23 19:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 15 '23 15:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 26 '23 14:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46605659

facebook-github-bot avatar Jun 27 '23 15:06 facebook-github-bot

This pull request was successfully merged by Matt Blagden in 48791bcd9873b4db10435077c0560907fdb263b2.

When will my fix make it into a release? | Upcoming Releases

github-actions[bot] avatar Jun 27 '23 17:06 github-actions[bot]

This pull request has been merged in facebook/react-native@48791bcd9873b4db10435077c0560907fdb263b2.

facebook-github-bot avatar Jun 27 '23 17:06 facebook-github-bot