react-native icon indicating copy to clipboard operation
react-native copied to clipboard

re: migrate ReactCookieJarContainerTest to Kotlin

Open pk-218 opened this issue 2 years ago • 2 comments

Summary:

This PR migrates ReactCookieJarContainerTest.java to Kotlin as a part of the issue #37708

Changelog:

[INTERNAL] [CHANGED] - Migrate ReactCookieJarContainerTest.java to Kotlin

Test Plan:

  1. Run ./gradlew :packages:react-native:ReactAndroid:test.
  2. All tests should pass.

pk-218 avatar Jun 09 '23 19:06 pk-218

@pk-218

Thanks for working on this one!

Sending back to you, though - the tests that you converted are failing, see here:

image

Also, I've left a couple of comments about minor stylistic issues, would appreciate if you address them as well :)

rshest avatar Jun 09 '23 23:06 rshest

Hey @pk-218, are you planning to follow up on this, or should we perhaps close it?

rshest avatar Jun 14 '23 22:06 rshest

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,425 -13,258
android hermes armeabi-v7a 8,056,635 -13,624
android hermes x86 9,235,558 -14,721
android hermes x86_64 9,086,375 -13,043
android jsc arm64-v8a 9,307,265 -11,570
android jsc armeabi-v7a 8,496,810 -11,932
android jsc x86 9,369,284 -13,037
android jsc x86_64 9,624,206 -11,356

Base commit: 2ae163a7e8f56861ba081ed3909d4a1d890930f1 Branch: main

analysis-bot avatar Jun 15 '23 21:06 analysis-bot

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 15 '23 21:06 facebook-github-bot

This pull request was successfully merged by @pk-218 in f1901d43d5bc5d579745e91f3bed09d7314ae6e1.

When will my fix make it into a release? | Upcoming Releases

github-actions[bot] avatar Jun 16 '23 11:06 github-actions[bot]

@rshest merged this pull request in facebook/react-native@f1901d43d5bc5d579745e91f3bed09d7314ae6e1.

facebook-github-bot avatar Jun 16 '23 11:06 facebook-github-bot