react-native
                                
                                 react-native copied to clipboard
                                
                                    react-native copied to clipboard
                            
                            
                            
                        re: migrate ReactCookieJarContainerTest to Kotlin
Summary:
This PR migrates ReactCookieJarContainerTest.java to Kotlin as a part of the issue #37708
Changelog:
[INTERNAL] [CHANGED] - Migrate ReactCookieJarContainerTest.java to Kotlin
Test Plan:
- Run ./gradlew :packages:react-native:ReactAndroid:test.
- All tests should pass.
@pk-218
Thanks for working on this one!
Sending back to you, though - the tests that you converted are failing, see here:
Also, I've left a couple of comments about minor stylistic issues, would appreciate if you address them as well :)
Hey @pk-218, are you planning to follow up on this, or should we perhaps close it?
| Platform | Engine | Arch | Size (bytes) | Diff | 
|---|---|---|---|---|
| android | hermes | arm64-v8a | 8,744,425 | -13,258 | 
| android | hermes | armeabi-v7a | 8,056,635 | -13,624 | 
| android | hermes | x86 | 9,235,558 | -14,721 | 
| android | hermes | x86_64 | 9,086,375 | -13,043 | 
| android | jsc | arm64-v8a | 9,307,265 | -11,570 | 
| android | jsc | armeabi-v7a | 8,496,810 | -11,932 | 
| android | jsc | x86 | 9,369,284 | -13,037 | 
| android | jsc | x86_64 | 9,624,206 | -11,356 | 
Base commit: 2ae163a7e8f56861ba081ed3909d4a1d890930f1 Branch: main
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
This pull request was successfully merged by @pk-218 in f1901d43d5bc5d579745e91f3bed09d7314ae6e1.
When will my fix make it into a release? | Upcoming Releases
@rshest merged this pull request in facebook/react-native@f1901d43d5bc5d579745e91f3bed09d7314ae6e1.