react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Codegen 92] move getCommandOptions to parsers-commons

Open tarunrajput opened this issue 2 years ago • 3 comments

Summary

Part of Codegen Umbrella Issue: #34872

[Codegen 92] The getCommandOptions function in parsers/typescript/components/options.js and parsers/flow/components/options.js is the same. move it in parser-commons and use it in the original files. If the file two options.js files are empty, delete them.

Changelog

[Internal][Changed] - Move getCommandOptions from both parsers components options file

Test Plan

yarn jest react-native-codegen

tarunrajput avatar Mar 08 '23 21:03 tarunrajput

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,516,930 -211
android hermes armeabi-v7a 7,832,996 -198
android hermes x86 8,997,196 -211
android hermes x86_64 8,852,303 -210
android jsc arm64-v8a 9,141,112 -56
android jsc armeabi-v7a 8,332,996 -66
android jsc x86 9,195,811 -47
android jsc x86_64 9,453,760 -62

Base commit: ccbbcaab9cf3e6148e72f94fe63f77ce5f92416c Branch: main

analysis-bot avatar Mar 08 '23 21:03 analysis-bot

Thanks for contributing to the umbrella project to Improve Codegen!

ryancat avatar Mar 09 '23 00:03 ryancat

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 09 '23 00:03 facebook-github-bot

/rebase

tarunrajput avatar Mar 09 '23 18:03 tarunrajput

/rebase

tarunrajput avatar Mar 13 '23 15:03 tarunrajput