react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Codegen_buildModuleSchema] extract buildModuleSchema to parsers-commons

Open tarunrajput opened this issue 2 years ago • 2 comments

Summary

Extract the buildModuleSchema function (Flow, TypeScript)in the parsers-commons.js function. The two functions are almost identical except for the filter(property =>) at the end of the function, which is different based on the language.

Part of Codegen Issue #34872 Depends on Codegen 74, Codegen 84.

Changelog

[INTERNAL] [CHANGED] - Extract buildModuleSchema from Flow and TypeScript parsers modules to parsers-commons

Test Plan

yarn lint && yarn run flow && yarn test react-native-codegen

tarunrajput avatar Feb 28 '23 18:02 tarunrajput

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,508,872 +0
android hermes armeabi-v7a 7,822,848 +0
android hermes x86 8,986,447 +0
android hermes x86_64 8,842,620 +0
android jsc arm64-v8a 9,135,684 +0
android jsc armeabi-v7a 8,325,234 +0
android jsc x86 9,188,637 +0
android jsc x86_64 9,447,629 +0

Base commit: 947751fbe4fd72c67538260df0136a2e184bb4fb Branch: main

analysis-bot avatar Mar 02 '23 19:03 analysis-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 06 '23 10:03 facebook-github-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 10 '23 11:03 facebook-github-bot

@cipolleschi merged this pull request in facebook/react-native@3cd97e4994b319f77c7afbf3a5dad5095b6ea9f3.

facebook-github-bot avatar Mar 10 '23 16:03 facebook-github-bot