react-native
react-native copied to clipboard
facebook
RNTester: Setup E2E tests for iOS and Android with Appium, Jest and Cucumber
Hi @adzironman!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
| Warnings | |
|---|---|
| :warning: | :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee. |
Generated by :no_entry_sign: dangerJS against b3d21be30ed0af3fcda4864d162d0c0b3142d368
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This Appium setup is cool, we made a babel plugin to find elements with testID, do check if it's useful in this setup. https://www.npmjs.com/package/babel-plugin-format-testid
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@NickGerleman @cipolleschi please ignore this PR for now, this is part 2 of https://github.com/facebook/react-native/pull/35786 but the team is still working on them both (you'll see that a good part of your comments I've already covered in the other PR).
I'll ping you once this 2nd PR should be looked at ;)
let's close this one in favour of https://github.com/facebook/react-native/pull/36267, things have changed enough that adding cucumber will need (if we decide to do it) much further down the line