react-native icon indicating copy to clipboard operation
react-native copied to clipboard

fix(release scripts): backport fixes for CI from 0.71 into main

Open kelset opened this issue 3 years ago • 2 comments

Summary

This PR backport two fixes we did in 0.71 to unblock the release process:

  • the change in publish-npm is needed because of the introduction of .strict() from https://github.com/facebook/react-native/commit/4f3ca8facfc41f27169c49ad8b3a28d3022d5f0a
  • the removal of the other script (added originally here https://github.com/facebook/react-native/commit/e4b5d3eec9bae44c46795c4be097b31cb48593ae) is because:
    1. that step is not needed anymore (we don't publish/upload hermes artifacts to the GH release)
    2. by the time this job gets run the release crew has already setup the GH release
    3. the logic for the versioning was broken and even on the 0.71-rc pipeline it was tagging stuff as 1000.0.0

Changelog

[Internal] [Fixed] - Fix release scripts for "release" pipeline scenario

Test Plan

The fact that 0.71-rc0 was released is the ✅ for this.

kelset avatar Nov 08 '22 12:11 kelset

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Nov 08 '22 12:11 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dac6806559c49b267ce6eb2722c9ff3b9108ead1 Branch: main

analysis-bot avatar Nov 08 '22 12:11 analysis-bot

This pull request was successfully merged by @kelset in cfa25e0a4aa5b86489c5ed3ad7c8ff7a7091b068.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Nov 08 '22 18:11 react-native-bot