react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

remove RCTFabricSurfaceHostingProxyRootView

Open philIip opened this issue 3 years ago • 13 comments

Summary: Changelog: [Internal]

looking to simplify our container view setup.

currently we have RCTFabricSurfaceHostingProxyRootView, RCTRootView, RCTSurfaceHostingView, and RCTSurfaceHostingProxyRootView. realistically we only need RCTRootView and RCTSurfaceHostingView.

in this diff, i get rid of RCTFabricSurfaceHostingProxyRootView by changing the logic where we have an inherited class method that determines whether to provide a fabric or legacy surface into a configuration param instead.

Differential Revision: D40781257

philIip avatar Oct 28 '22 22:10 philIip

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Oct 28 '22 22:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Nov 02 '22 21:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Nov 02 '22 22:11 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,278 +0
android hermes armeabi-v7a 6,471,460 +0
android hermes x86 7,519,589 +0
android hermes x86_64 7,378,046 +0
android jsc arm64-v8a 8,967,048 +0
android jsc armeabi-v7a 7,697,908 +0
android jsc x86 9,029,188 +0
android jsc x86_64 9,507,038 +0

Base commit: 418e95799f3477d58725690c5c99e2412cb581e1 Branch: main

analysis-bot avatar Nov 02 '22 22:11 analysis-bot

PR build artifact for 1b28aeb3d8052c1cda783df7c6cabf0362bd6231 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 02 '22 23:11 pull-bot

PR build artifact for 1b28aeb3d8052c1cda783df7c6cabf0362bd6231 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 02 '22 23:11 pull-bot

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Nov 03 '22 14:11 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 418e95799f3477d58725690c5c99e2412cb581e1 Branch: main

analysis-bot avatar Nov 03 '22 15:11 analysis-bot

PR build artifact for 33e7aa945380768381c18e8a675176c64575cdb2 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 03 '22 15:11 pull-bot

PR build artifact for 33e7aa945380768381c18e8a675176c64575cdb2 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 03 '22 15:11 pull-bot

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Nov 03 '22 20:11 facebook-github-bot

PR build artifact for f96646876f66ad0d232ad2e6b3c0b4ca1aed63e5 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 03 '22 21:11 pull-bot

PR build artifact for f96646876f66ad0d232ad2e6b3c0b4ca1aed63e5 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 03 '22 21:11 pull-bot

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Nov 11 '22 05:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D40781257

facebook-github-bot avatar Nov 17 '22 03:11 facebook-github-bot

PR build artifact for d6845dfdc4d6b5b7d29eec1a09ad28959e61573f is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 17 '22 04:11 pull-bot

PR build artifact for d6845dfdc4d6b5b7d29eec1a09ad28959e61573f is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 17 '22 04:11 pull-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 16 '23 06:05 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 31 '23 05:05 github-actions[bot]