react-native
react-native copied to clipboard
Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties
Summary: I've rewritten the comment in the android/app/build.gradle. They were really old, contained wrong links and most of the people ignored it.
I've also moved the enabling of Hermes to the gradle.properties file.
RNGP still supports the old method, but we must be sure that we notify
library authors if they were reading project.ext.react.enableHermes in the past
(also the website needs to be updated).
I've also cleaned up the CircleCI setup as now we can specify Hermes enabled/disabled via the CLI (this will also make easier to do e2e testing).
Changelog: [Android] [Changed] - Cleanup the template documentation after RNGP & hermesEnabled to gradle.properties
Differential Revision: D40762872
This pull request was exported from Phabricator. Differential Revision: D40762872
This pull request was exported from Phabricator. Differential Revision: D40762872
This pull request was exported from Phabricator. Differential Revision: D40762872
This pull request was exported from Phabricator. Differential Revision: D40762872
This pull request was exported from Phabricator. Differential Revision: D40762872
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 7,001,888 | +495 |
| android | hermes | armeabi-v7a | 6,378,328 | +461 |
| android | hermes | x86 | 7,414,780 | +832 |
| android | hermes | x86_64 | 7,278,674 | +802 |
| android | jsc | arm64-v8a | 8,867,565 | +0 |
| android | jsc | armeabi-v7a | 7,605,882 | +0 |
| android | jsc | x86 | 8,925,465 | +0 |
| android | jsc | x86_64 | 9,408,701 | +0 |
Base commit: ba5454c42134cc09772f024772b19a9990b1fb7f Branch: main
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| ios | - | universal | n/a | -- |
Base commit: ba5454c42134cc09772f024772b19a9990b1fb7f Branch: main
PR build artifact for be72feb4b024968dfa86bf5b7db60c5b6ec59b70 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for be72feb4b024968dfa86bf5b7db60c5b6ec59b70 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
This pull request was successfully merged by @cortinico in 6a43fafd78d581f63c664b9af6d10828ac7f77fa.
When will my fix make it into a release? | Upcoming Releases