react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Sets the namespace via Gradle and not via AndroidManifest

Open cortinico opened this issue 3 years ago • 6 comments

Summary: Currently the build on console is firing this warning:

> Task :app:processDebugMainManifest
package="com.androidtemplateproject" found in source AndroidManifest.xml: /tmp/AndroidTemplateProject/android/app/src/main/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

This diff fixes it so users won't see it anymore on 0.71

Changelog: [Android] [Fixed] - Sets the namespace via Gradle and not via AndroidManifest

Differential Revision: D40724654

cortinico avatar Oct 26 '22 17:10 cortinico

This pull request was exported from Phabricator. Differential Revision: D40724654

facebook-github-bot avatar Oct 26 '22 17:10 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ec5a4301a3c23af7d1c7f39d13e57be113c84f6a Branch: main

analysis-bot avatar Oct 26 '22 17:10 analysis-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,003,350 +0
android hermes armeabi-v7a 6,379,695 +0
android hermes x86 7,416,186 +0
android hermes x86_64 7,280,093 +0
android jsc arm64-v8a 8,868,346 +0
android jsc armeabi-v7a 7,606,652 +0
android jsc x86 8,926,232 +0
android jsc x86_64 9,409,473 +0

Base commit: 662115077a9d7dab260ec93d89c7ca02145a47f8 Branch: main

analysis-bot avatar Oct 26 '22 17:10 analysis-bot

PR build artifact for 0c0d3d4cbfd666c7410fab8d2362e96d1a8e4da9 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 26 '22 17:10 pull-bot

PR build artifact for 0c0d3d4cbfd666c7410fab8d2362e96d1a8e4da9 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 26 '22 17:10 pull-bot

Currently blocked by https://github.com/react-native-community/cli/pull/1727

cortinico avatar Oct 27 '22 10:10 cortinico

This pull request was exported from Phabricator. Differential Revision: D40724654

facebook-github-bot avatar Oct 28 '22 08:10 facebook-github-bot

PR build artifact for 1f143e80a985c8e5a44bb4be593ae7f067b1d7dd is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 28 '22 09:10 pull-bot

PR build artifact for 1f143e80a985c8e5a44bb4be593ae7f067b1d7dd is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 28 '22 09:10 pull-bot

This pull request was exported from Phabricator. Differential Revision: D40724654

facebook-github-bot avatar Oct 29 '22 10:10 facebook-github-bot

PR build artifact for 37464d3dad9d7c5627d44aadd52b07d208ff6c80 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 29 '22 11:10 pull-bot

PR build artifact for 37464d3dad9d7c5627d44aadd52b07d208ff6c80 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 29 '22 11:10 pull-bot

This pull request was successfully merged by @cortinico in cec9a34f6cd2a82bba76e15761da6b588bc3f574.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Oct 29 '22 13:10 react-native-bot