react-native
react-native copied to clipboard
facebook
chore(deps): add wanted dependencies to remove yarn warnings
Summary
I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.
It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.
Also, while doing that I found a dependency that was lying there unused for 2 years so took care of it.
Changelog
[General] [Fixed] - add wanted dependencies to remove yarn warnings
Test Plan
Before
After
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| ios | - | universal | n/a | -- |
Base commit: fd917481463bf6ba9c4e14919250aec2ffad2c2f Branch: main
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@robhogan no problem, thanks for the suggestions, I've applied them! Is there some tooling that we could use to automate this? Kind of like prettier but for package.json? 😅
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@robhogan no problem, thanks for the suggestions, I've applied them! Is there some tooling that we could use to automate this? Kind of like prettier but for package.json? 😅
Yeah we should, tbh I thought we had an autofix lint rule for it already. Yarn and NPM auto-sort whenever they modify the file iirc, but it looks like we don't have any check - package-json/sort-collections would work. CC @cipolleschi
This pull request was successfully merged by @kelset in 8422c5315caf5cf696791a5ad49ed0fbd37ef9df.
When will my fix make it into a release? | Upcoming Releases
This pull request has been reverted by cf5addf423b346dd43204f676c42f0a428f9af9c.
Reopening as this was reverted due to an (apparently) missing internal dependency that previously worked transitively.
Meta folks: See D40716713 before re-landing.
@robhogan quick check, anything I can do to help get this in? do you want me to rebase it on top of main?
@robhogan quick check, anything I can do to help get this in? do you want me to rebase it on top of main?
Sorry about this, nothing you can do from the OSS end. Removing the @reactions/component dependency is tripping up Flow internally for reasons that are unclear at the moment, some config/resolution bug - we're working on it.
If it'd help you to get this in, you could submit a new PR (has to be new - this one can't be re-imported now it's been committed) without the @reactions/component removal, that should be a straightforward merge.
Otherwise, I'm hoping we can unblock this within a few days.