react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Restore Filtering platform in codegen

Open cipolleschi opened this issue 3 years ago • 3 comments

Summary: This Diff require a bump in the react-native-codegen (including this commit) to work

This diff sets up iOS and Android to pass their platform to the codegen so that we can have platform-specific specs.

Changelog

[General][Added] - Enable platform-specific Codegen Specs

Differential Revision: D40516395

cipolleschi avatar Oct 19 '22 17:10 cipolleschi

This pull request was exported from Phabricator. Differential Revision: D40516395

facebook-github-bot avatar Oct 19 '22 17:10 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,003,369 +0
android hermes armeabi-v7a 6,379,713 +0
android hermes x86 7,416,216 +0
android hermes x86_64 7,280,112 +0
android jsc arm64-v8a 8,868,341 +0
android jsc armeabi-v7a 7,606,658 +0
android jsc x86 8,926,237 +0
android jsc x86_64 9,409,481 +0

Base commit: 76c7ccaa60c4e820757c5d8cd8ccc80a2cb5f4a0 Branch: main

analysis-bot avatar Oct 19 '22 17:10 analysis-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 76c7ccaa60c4e820757c5d8cd8ccc80a2cb5f4a0 Branch: main

analysis-bot avatar Oct 19 '22 18:10 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D40516395

facebook-github-bot avatar Oct 31 '22 15:10 facebook-github-bot

PR build artifact for d279fcc434e317eed9f57daf68702621b50d1452 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 31 '22 15:10 pull-bot

PR build artifact for d279fcc434e317eed9f57daf68702621b50d1452 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 31 '22 15:10 pull-bot

This pull request was successfully merged by @cipolleschi in ab7b4d4cd89cf6a7cb76d2b6a60163919cc3c689.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Oct 31 '22 19:10 react-native-bot