react-native
react-native copied to clipboard
facebook
chore: renamed react-native-codegen to @react-native/codegen
Summary
Renamed react-native-codegen package to @react-native/codegen and updated references, without changing the folder name; part of RFC480 (#34692). Follow-up from https://github.com/facebook/react-native/pull/34578
Changelog
[General] [Changed] - Renamed react-native-codegen package to @react-native/codegen and updated references
Test Plan
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cortinico done. I'm not seeing the test_js task btw - CircleCI isn't running. Is there something more I need to do for that?
something more I need to do for that?
Let's try to rebase. If it's still not working, I'll try to look more closely into this
@cortinico done. I'm getting a "workflow awaiting approval" message - perhaps that's why CircleCI did not run?
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 7,103,533 | +0 |
| android | hermes | armeabi-v7a | 6,471,857 | +0 |
| android | hermes | x86 | 7,521,168 | +0 |
| android | hermes | x86_64 | 7,380,054 | +0 |
| android | jsc | arm64-v8a | 8,968,359 | +0 |
| android | jsc | armeabi-v7a | 7,699,467 | +0 |
| android | jsc | x86 | 9,030,658 | +0 |
| android | jsc | x86_64 | 9,508,690 | +0 |
Base commit: ca1ae5c44ffa0b1a149e69e47b7f51cb6a914734 Branch: main
Hey @shivenmian, I've rebased your PR as the CI was not running.
Now eslint is failing on CI. Are you able to take a look at it?
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| ios | - | universal | n/a | -- |
Base commit: ca1ae5c44ffa0b1a149e69e47b7f51cb6a914734 Branch: main
@cortinico fixed and rebased. Should pass now once you approve the workflow / run circleci
CircleCI is failing to run on this PR, not sure why. I've attempted an autorebase, let's see if this unblocks the situation
@cortinico looks like the JS loop passed. It doesn't seem like the Android / Windows loop failures are related to this, and the iOS one seems like it can't find @react-native/codegen from npm - this should be fixed once the package change makes it way up to npm as well?
@cortinico this good to go?
Sorry I was off some days and missed this ping. The PR seems good to go. I'm investigating if we can use Verdaccio also for the template tests similarly to what we did here https://github.com/facebook/react-native/pull/34577
Is this something you would be interested in looking into setting up for the whole React Native repo (as this would unblock a lot of other PRs like this one).
Sure. Quick question:
I'm investigating if we can use Verdaccio also for the template tests similarly to what we did here #34577
By "template tests", do you mean the tests that are failing right now on this PR (i.e test_android_template_... and test_ios_template_...)?
By "template tests", do you mean the tests that are failing right now on this PR (i.e test_android_template_... and test_ios_template_...)?
Yes exactly 👍
Hey @shivenmian, thanks for contributing. To make this work (both internally and in open-source) I need to add some changes. Could you please share if this is okay for you?
PR build artifact for c6b4f6961daa8dbc9533abaefb06ffb90d763151 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for c6b4f6961daa8dbc9533abaefb06ffb90d763151 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for b9a36dfd394890f51f3a1aebb720c600b1e4ac57 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for b9a36dfd394890f51f3a1aebb720c600b1e4ac57 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for d2840780bdd7c781dd1599d39869d7a666fd990a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for d2840780bdd7c781dd1599d39869d7a666fd990a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for 720b05d5e4ecdb94158842d62a9c67337dab4d0a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for 720b05d5e4ecdb94158842d62a9c67337dab4d0a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
PR build artifact for 512523e787d3ceb3a54142aaa978a2ea3bb49e83 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for 512523e787d3ceb3a54142aaa978a2ea3bb49e83 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.