react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Create minimal reproduction for mvcp bug

Open roryabraham opened this issue 3 years ago • 5 comments

This is just a diff to show a minimal reproduction of a bug using the rn-tester app.

roryabraham avatar Feb 25 '22 17:02 roryabraham

Hi @roryabraham!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 25 '22 17:02 facebook-github-bot

Messages
:book:

:clipboard: Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
:book: :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
:book: :clipboard: Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by :no_entry_sign: dangerJS against bcad6a16319632f6ceb32ebab1aa0e248d7d00bf

pull-bot avatar Feb 25 '22 17:02 pull-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dc50308994f2c645099d4c5c41469ed572ca1896 Branch: main

analysis-bot avatar Feb 25 '22 17:02 analysis-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,193,543 -9,671
android hermes armeabi-v7a 7,800,597 -9,653
android hermes x86 8,565,710 -9,718
android hermes x86_64 8,516,330 -9,713
android jsc arm64-v8a 9,867,945 -4,013
android jsc armeabi-v7a 8,859,531 -3,996
android jsc x86 9,836,197 -4,057
android jsc x86_64 10,430,923 -4,073

Base commit: 267d36d0afb4b3713df9b679c2019c44ac6bcc3f Branch: main

analysis-bot avatar Feb 25 '22 18:02 analysis-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 25 '22 02:08 github-actions[bot]