react-native icon indicating copy to clipboard operation
react-native copied to clipboard

add render node utility

Open jdnichollsc opened this issue 4 years ago • 7 comments

Summary

Motivation is to create a simple utility to reuse the validation to render a node from any component.

Changelog

[General] [Added] - Add render node utility to be used with component props

Test Plan

Added test with react-test-renderer to validate the same output for a simple test component

jdnichollsc avatar Mar 10 '21 00:03 jdnichollsc

Hi @jdnichollsc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 10 '21 00:03 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Mar 10 '21 00:03 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4170726dfa947077170daf2f1c9c222fc88f073d

analysis-bot avatar Mar 10 '21 01:03 analysis-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,908,370 -36
android hermes armeabi-v7a 8,407,445 -32
android hermes x86 9,398,924 -29
android hermes x86_64 9,342,844 -35
android jsc arm64-v8a 10,642,349 +29
android jsc armeabi-v7a 10,124,527 +48
android jsc x86 10,694,405 +39
android jsc x86_64 11,278,588 +30

Base commit: 4170726dfa947077170daf2f1c9c222fc88f073d

analysis-bot avatar Mar 10 '21 01:03 analysis-bot

Please let me know what you think about types, I'm not expert with flow, this is my example with TypeScript: https://github.com/proyecto26/MyApp/blob/develop/src/helpers/renderNode.tsx#L3

Thanks for your help!

jdnichollsc avatar Mar 10 '21 15:03 jdnichollsc

Please let me know if you are interested in my changes and I can resolve the merge conflicts

jdnichollsc avatar Jun 03 '21 04:06 jdnichollsc

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 23 '24 05:04 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Apr 30 '24 05:04 github-actions[bot]