react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

[TextInput]: Add missing value 'go' in enterKeyHint prop

Open tarunrajput opened this issue 2 years ago • 4 comments

enterKeyHint supports following values but docs are missing one value go. Also, enter is equivalent to UIReturnKeyType default and supported in iOS only.

export type enterKeyHintType =
  // Cross Platform
  | 'done'
  | 'go'
  | 'next'
  | 'search'
  | 'send'
  // Android-only
  | 'previous'
  // iOS-only
  | 'enter';
image

Tests

https://deploy-preview-3739--react-native.netlify.app/docs/textinput#enterkeyhint

tarunrajput avatar May 31 '23 06:05 tarunrajput

Deploy Preview for react-native ready!

Name Link
Latest commit 049120cf31143e730092ec2d04a2b6122d5e0b6d
Latest deploy log https://app.netlify.com/sites/react-native/deploys/65748bc4380e530007c3e05c
Deploy Preview https://deploy-preview-3739--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 31 '23 06:05 netlify[bot]

@Simek, could we merge this?

tarunrajput avatar Dec 08 '23 11:12 tarunrajput

@Simek, could we merge this?

I believe yes, not sure why @Simek you added "Waiting on future release"

cortinico avatar Dec 08 '23 13:12 cortinico

I believe that I have added labels since at te moment of PR publish, changes has not been merged to core repo yet, and thus was not sure when they land and which version the changes be a part of. Usually we update those labels in docs after the PRs land, or when preparing docs cut for new version.

@tarunrajput Can you backport the changes to versioned 0.73 docs before we ship this out, since this change has landed as a part of this release?

Simek avatar Dec 09 '23 14:12 Simek