create-react-app
create-react-app copied to clipboard
facebook
add support for cjs files in project and in modules
I'm having problems using modules that ship files with .cjs extension, these config changes should allow these files to be processed as other js files.
Hi @mcfedr!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Please review this PR, I faced the same issue when an ESM dependency that contains a .cjs (generated file) (see https://github.com/status-im/js-waku/issues/895)
This PR is a duplicate of #12021! I believe this would fix #12155. Hoping for this to be reviewed and merged!
Oh please please review this so that the past 3 days of my life were not in vain! 💀
