create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

Update App.js

Open MarcusMorba opened this issue 3 years ago • 6 comments
trafficstars

Due to the general importance of digital accessibility in general and even more in the future I would be very glad if the REACT Team could improve this template to create valid markup. One of the major issues I see, when I support development teams working with react very often is "missing

-landmark".

Besides that to raise the awareness for accessibility it would be awesome to add some links to basic accessibility documentation. THANKS in advance.

image

MarcusMorba avatar Jul 17 '22 09:07 MarcusMorba

Hi @MarcusMorba!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 17 '22 09:07 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 17 '22 10:07 facebook-github-bot

@mrmckeb - as a first-time contributor I need a maintainer to approve running workflow.

3 workflows awaiting approval First-time contributors need a maintainer to approve running workflows.

MarcusMorba avatar Jul 20 '22 06:07 MarcusMorba

@mrmckeb - Hi Brody, converted the PR to draft and would be happy about your feedback. If the changes are to much, I would add this PR as a feature request.

MarcusMorba avatar Jul 21 '22 05:07 MarcusMorba

@ianschmitz & @mrmckeb - please give some feedback. Thanks.

MarcusMorba avatar Aug 18 '22 11:08 MarcusMorba

@ianschmitz & @mrmckeb - I am still hoping for some feedback. Thanks.

MarcusMorba avatar Sep 10 '22 05:09 MarcusMorba

Giving up and will avoid anything met and react in the future wherever I can. All my clients need to believe me, if I say "react is not accessible", as no clients can prove the opposite and your official documentation just proves you do not care. Thanks. Let´s go #vueJS #dotNet image

MarcusMorba avatar Mar 19 '23 12:03 MarcusMorba