create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

`eslint-config-react-app` should provide `@babel/plugin-syntax-flow` and `@babel/plugin-transform-react-jsx`

Open quisido opened this issue 3 years ago • 1 comments

Describe the bug

Installing eslint-config-react-app results in these two warnings:

➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-syntax-flow (pc2f30), requested by eslint-plugin-flowtype
➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-transform-react-jsx (p4cc0d), requested by eslint-plugin-flowtype

Environment

Yarn 3

Steps to reproduce

  1. yarn install

Expected behavior

eslint-config-react-app should correctly depend on @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx

Actual behavior

Warning


The fix for this is either too add @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx to the dependencies of eslint-config-react-app's package.json file or to its peerDependencies. I didn't know which is desired between the two (I assume peerDependencies, but I know ESLint can be finicky about nested dependencies), so I didn't want to cut a PR with the wrong change.

quisido avatar Jun 01 '22 21:06 quisido

I'm seeing this, too. Also, adding the dependency to my project's list doesn't resolve the warning because the warning doesn't occur in my workspace.

nathan-alden-sr avatar Aug 22 '22 21:08 nathan-alden-sr

Is there a workaround for this?

doronhorwitz avatar Feb 14 '23 09:02 doronhorwitz

@doronhorwitz Sort of: #11982

ndmax avatar Feb 19 '23 13:02 ndmax