PathPicker icon indicating copy to clipboard operation
PathPicker copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Demo videos in homepage not loading on mobile

Open code-reaper08 opened this issue 4 years ago • 2 comments
trafficstars

Describe the bug Demo videos in homepage are not visible and leave a blank space in mobile browsers. To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://facebook.github.io/PathPicker/' using mobile.
  2. Videos there don't display and leaves a space.

Expected behavior The demo videos could have a fallback on mobile browsers, which makes them an image redirecting to the actual video demo.

Screenshots in mobile browser demo_video_missing in desktop browser demo_video_present

Desktop:

  • OS: Windows 10 pro
  • Browser: chrome Version 92.0.4515.107 (Official Build) (64-bit), firefox 90.0.2 (64-bit)

Smartphone:

  • Browser: chrome, firefox

Additional context I am working on this issue currently and would make a PR in a couple of days. if you don't mind please assign this to me. Thanks in advance 😄

code-reaper08 avatar Jul 23 '21 18:07 code-reaper08

I checked it in Safari on iPhone and there it works fine. Probably only Android is affected?

KapJI avatar Jul 24 '21 19:07 KapJI

I checked it in Safari on iPhone and there it works fine. Probably only Android is affected?

Thanks for your reply @KapJI Most probably YES if it works on Safari, Only android is affected. Is there anything we can do?

BTW I am not sure what causes this issue 😕

Tried implementing a fallback for mobile devices to make the video as an image, sadly that too is not rendered.

code-reaper08 avatar Jul 24 '21 19:07 code-reaper08