Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Mock out ax_parameter_sens in online/offline tests

Open mpolson64 opened this issue 7 months ago • 2 comments
trafficstars

Summary: Should be safe since ax_parameter_sens is tested elsewhere.

These tests try and call compute() using over 100 different experiments, making each test very expensive -- this doubled our OSS unit testing time. With these changes the tests go from taking ~300s to ~50s on my machine in dev mode.

Differential Revision: D73066856

mpolson64 avatar Apr 15 '25 23:04 mpolson64

This pull request was exported from Phabricator. Differential Revision: D73066856

facebook-github-bot avatar Apr 15 '25 23:04 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.08%. Comparing base (82c553a) to head (8750265).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3648   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         550      550           
  Lines       54368    54371    +3     
=======================================
+ Hits        52241    52244    +3     
  Misses       2127     2127           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 15 '25 23:04 codecov-commenter