Ax
Ax copied to clipboard
facebook
Clean up derelativize_with_raw_status_quo
Summary:
We were setting derelativize_with_raw_status_quo to True across the board (in choose_gs_internal) because the Winsorize transform did not support relative constraints when it was False. If a config has only one valid value, it seems simpler to make that the default behavior and eliminate the config. This is exactly what this diff does.
Also cleaned up some long deprecated config options from Winsorize and all usage of derelativize_with_raw_status_quo across the dispatch utils.
This config was occasionally passed to the Derelativize transform as well. When it comes to Derelativize, the consensus seems to be that we want to derelativize using the model predictions, so that the model predictions that are compared to the derelativized constraints are on the same scale as the constraint values. So, it doesn't seem to be necessary to use this with Derelativize either.
Backwards compatibility: Choose GS does not have any storage associated with it, so no concerns there unless some notebook was explicitly passing this in. The old configs should be loaded and passed into the transforms without issues, as the unexpected kwargs will be silently ignored.
Differential Revision: D71225747
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.96%. Comparing base (
de50823) to head (0662933).
Additional details and impacted files
@@ Coverage Diff @@
## main #3508 +/- ##
==========================================
- Coverage 96.02% 95.96% -0.06%
==========================================
Files 537 536 -1
Lines 52802 52674 -128
==========================================
- Hits 50702 50548 -154
- Misses 2100 2126 +26
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
