Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Make choose_analyses pass on base and be an abstract method

Open mgarrard opened this issue 9 months ago • 2 comments

Summary: The implementation of choose_analyses should always be done depending on other attributes, and we have those exisiting methods elsewhere. This seems like it was initially implemented this way during development of the stack and never cleaned up - just cleaning it up as i go.

Differential Revision: D70641832

mgarrard avatar Mar 05 '25 23:03 mgarrard

This pull request was exported from Phabricator. Differential Revision: D70641832

facebook-github-bot avatar Mar 05 '25 23:03 facebook-github-bot

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (36d55fc) to head (c1c38d4).

Files with missing lines Patch % Lines
ax/service/utils/analysis_base.py 66.66% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3469   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         539      539           
  Lines       52886    52887    +1     
=======================================
+ Hits        50785    50786    +1     
  Misses       2101     2101           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Mar 06 '25 00:03 codecov-commenter