Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Move new dispatch utils out of preview

Open mpolson64 opened this issue 8 months ago • 10 comments

Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree.

Differential Revision: D70647193

mpolson64 avatar Mar 05 '25 21:03 mpolson64

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 05 '25 21:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 05 '25 22:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 05 '25 22:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 05 '25 22:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 05 '25 22:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 06 '25 01:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 06 '25 01:03 facebook-github-bot

Codecov Report

Attention: Patch coverage is 99.48718% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (4473fe7) to head (4970fa6).

Files with missing lines Patch % Lines
ax/generation_strategy/dispatch_utils.py 96.96% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3468      +/-   ##
==========================================
- Coverage   96.03%   96.02%   -0.01%     
==========================================
  Files         539      537       -2     
  Lines       52904    52887      -17     
==========================================
- Hits        50804    50787      -17     
  Misses       2100     2100              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Mar 06 '25 01:03 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 06 '25 04:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D70647193

facebook-github-bot avatar Mar 06 '25 04:03 facebook-github-bot