Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Improve robustness in InteractionAnalysis

Open mpolson64 opened this issue 9 months ago • 6 comments

Summary: A number of features to improve reliablity of the InteractionAnalysis.

  • Hide OAK kernel behind a flag which defaults to False. When false, use the current GenerationNode's adapter
  • If ax_parameter_sens fails log an exception and fallback to the surrogate's feature_importances
  • Do not plot samples on the slice and countour plots if there are more than 50 samples (it gets too cluttered)
  • Changed the orange and blue colors on the importance bar chart to be in the plotly color scheme
  • Make plot not error out on unordered choice params
  • Improved subtitle

Differential Revision: D69993111

mpolson64 avatar Feb 21 '25 21:02 mpolson64

This pull request was exported from Phabricator. Differential Revision: D69993111

facebook-github-bot avatar Feb 21 '25 21:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D69993111

facebook-github-bot avatar Feb 21 '25 21:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D69993111

facebook-github-bot avatar Feb 24 '25 18:02 facebook-github-bot

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.97%. Comparing base (c64d122) to head (94f29ba).

Files with missing lines Patch % Lines
ax/analysis/plotly/interaction.py 61.90% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3407      +/-   ##
==========================================
- Coverage   95.98%   95.97%   -0.02%     
==========================================
  Files         539      539              
  Lines       52791    52836      +45     
==========================================
+ Hits        50674    50711      +37     
- Misses       2117     2125       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 24 '25 18:02 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D69993111

facebook-github-bot avatar Feb 24 '25 20:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D69993111

facebook-github-bot avatar Feb 24 '25 23:02 facebook-github-bot