Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Deprecate GenerationStrategyInterface

Open paschai opened this issue 9 months ago • 2 comments

Summary: As titled - part of the January 2025 Better Engineering Sprint

The high level goal is to eventually migrate RemoteGS → RemoteGenNode, but after some discussions, we have decided to take the following actions:

  1. Deprecate RemoteGS (there are no use cases for it as of today)
  2. Deprecate GenerationStrategyInterface
  3. Implement RemoteGenNode when the use case surfaces

This diff is for step 2, and follow up diffs will be made for step 3 when needed

Differential Revision: D69253188

paschai avatar Feb 10 '25 21:02 paschai

This pull request was exported from Phabricator. Differential Revision: D69253188

facebook-github-bot avatar Feb 10 '25 21:02 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.70%. Comparing base (0809eb3) to head (6a9406f).

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3338    +/-   ##
========================================
  Coverage   95.70%   95.70%            
========================================
  Files         533      531     -2     
  Lines       52537    52427   -110     
========================================
- Hits        50278    50173   -105     
+ Misses       2259     2254     -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 10 '25 21:02 codecov-commenter