Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Cleanup of type issues in models/model_utils

Open esantorella opened this issue 10 months ago • 2 comments
trafficstars

Summary: A TypeVar indicates that multiple objects (e.g. an argument and a return type) are the same type. Using TypeVars with functions that work with either numpy arrays or torch tensors indicates that either everything is a numpy array or everything is a tensor. Otherwise, Pyre has no idea whether arrays might be randomly turning into tensors and vice versa.

Differential Revision: D68332888

esantorella avatar Jan 17 '25 20:01 esantorella

This pull request was exported from Phabricator. Differential Revision: D68332888

facebook-github-bot avatar Jan 17 '25 20:01 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.88%. Comparing base (81fba5c) to head (d2eb27c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
- Coverage   95.88%   95.88%   -0.01%     
==========================================
  Files         513      513              
  Lines       51689    51687       -2     
==========================================
- Hits        49562    49560       -2     
  Misses       2127     2127              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 17 '25 20:01 codecov-commenter