Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Combine experiment and gs fields into AnalysisBase

Open danielcohenlive opened this issue 1 year ago • 5 comments

Summary: AnalysisBase will have optional _experiment and _generation_strategy fields, with getter and setter properties, as well as the standard_generation_strategy prop from Scheduler. Scheduler and AxClient will inherit these from it.

The naming is less than optimal with AnalysisBase holding the experiment and GS.

This is otherwise a no-op change designed to reduce pyre errors.

Differential Revision: D66712036

danielcohenlive avatar Dec 03 '24 20:12 danielcohenlive

This pull request was exported from Phabricator. Differential Revision: D66712036

facebook-github-bot avatar Dec 03 '24 20:12 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D66712036

facebook-github-bot avatar Dec 03 '24 23:12 facebook-github-bot

Codecov Report

Attention: Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (e0ff0b4) to head (8eb3e55).

Files with missing lines Patch % Lines
ax/service/utils/analysis_base.py 97.82% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3137   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         498      499    +1     
  Lines       50518    50536   +18     
=======================================
+ Hits        48388    48406   +18     
  Misses       2130     2130           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 03 '24 23:12 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D66712036

facebook-github-bot avatar Dec 05 '24 21:12 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D66712036

facebook-github-bot avatar Dec 05 '24 21:12 facebook-github-bot