Ax icon indicating copy to clipboard operation
Ax copied to clipboard

InteractionPlot refactor

Open mpolson64 opened this issue 1 year ago • 3 comments

Summary: When this is landed we will be able to use this plot in Ax 1.0 and Ax UI.

Refactor the interaction plot to be in line with our structure for ax.analysis. This includes a massive reduction in overall code (about half) and a full decoupling from ax.plot.

Adds robustness features around generating subplots -- a failed surface subplot will no longer fail the full analysis.

This new version of the plot is slightly more opinionated in that we always plot both the feature importance bar chart AND the top 6 features, always plots top 15 components in the bar chart, never decomposes components, and always has plots share scale. These settings are most useful and help drastically simplify the code, so I think we should keep them for now and only consider adding them back if there is demand.

Differential Revision: D65234856

mpolson64 avatar Nov 21 '24 05:11 mpolson64

This pull request was exported from Phabricator. Differential Revision: D65234856

facebook-github-bot avatar Nov 21 '24 05:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D65234856

facebook-github-bot avatar Nov 21 '24 05:11 facebook-github-bot

Codecov Report

Attention: Patch coverage is 94.50172% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.73%. Comparing base (1efbcbd) to head (4e95ad2).

Files with missing lines Patch % Lines
ax/analysis/plotly/surface/utils.py 57.14% 9 Missing :warning:
ax/analysis/plotly/surface/contour.py 93.61% 3 Missing :warning:
ax/analysis/plotly/interaction.py 97.53% 2 Missing :warning:
ax/analysis/plotly/surface/slice.py 95.91% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3097      +/-   ##
==========================================
- Coverage   95.74%   95.73%   -0.01%     
==========================================
  Files         488      496       +8     
  Lines       49769    50060     +291     
==========================================
+ Hits        47653    47927     +274     
- Misses       2116     2133      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov-commenter avatar Nov 21 '24 05:11 codecov-commenter