Ax icon indicating copy to clipboard operation
Ax copied to clipboard

ReductionCriterion` to inherit from `FuncEnum` (which will help it play well with serialization and storage)

Open lena-kashtelyan opened this issue 1 year ago • 4 comments

Summary: As titled, applying the new FuncEnum util

Reviewed By: mgarrard

Differential Revision: D63914987

lena-kashtelyan avatar Oct 18 '24 15:10 lena-kashtelyan

This pull request was exported from Phabricator. Differential Revision: D63914987

facebook-github-bot avatar Oct 18 '24 15:10 facebook-github-bot

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.68%. Comparing base (322ea96) to head (f6e35d1).

Files with missing lines Patch % Lines
ax/modelbridge/tests/test_generation_strategy.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2915   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         504      504           
  Lines       49531    49559   +28     
=======================================
+ Hits        47395    47422   +27     
- Misses       2136     2137    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 18 '24 15:10 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D63914987

facebook-github-bot avatar Oct 24 '24 17:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63914987

facebook-github-bot avatar Nov 01 '24 00:11 facebook-github-bot