Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Replace AnalysisCardLevel with int

Open mpolson64 opened this issue 1 year ago • 5 comments

Summary: After discussion we decided we wanted more granular control over priority levels. We encourage all Analysis authors to continue using AnalysisCardLevel as a starting point, but if necessary they can adjust by adding or subtracting an integer.

Differential Revision: D64261171

mpolson64 avatar Oct 11 '24 20:10 mpolson64

This pull request was exported from Phabricator. Differential Revision: D64261171

facebook-github-bot avatar Oct 11 '24 20:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64261171

facebook-github-bot avatar Oct 11 '24 20:10 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.78%. Comparing base (5a5c4c4) to head (52a35ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         502      502              
  Lines       49604    49603       -1     
==========================================
- Hits        47511    47510       -1     
  Misses       2093     2093              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 11 '24 20:10 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D64261171

facebook-github-bot avatar Oct 15 '24 15:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64261171

facebook-github-bot avatar Oct 15 '24 15:10 facebook-github-bot

This pull request has been merged in facebook/Ax@cfb0e014988f52e7ade851e41e9f226dd1b615d5.

facebook-github-bot avatar Oct 16 '24 21:10 facebook-github-bot